Attention is currently required from: laforge.

View Change

4 comments:

• File src/bankd/gsmtap.c:

  • Patch Set #2, Line 28: osmo_bankd_gsmtap_init

    AFAIR, in simtrace2.git they are actually part of libosmo-simtrace2. […]

    Ack

  • Patch Set #2, Line 35: perror("unable to open GSMTAP");

    thanks for pointing this out, that's clearly a bug in libosmo-simtrace2 then.

    Ack

  • Patch Set #2, Line 56: uint8_t *buf = malloc(gross_len);

    Nice-- I'd never heard of writev(). Very useful. […]

    Ack

  • Patch Set #2, Line 83: perr

    normally we'd want to use the libosmocore logging framework with LOGL_ERROR here.

    Ack

To view, visit change 30139. To unsubscribe, or for help writing mail filters, visit settings.