[S] Change in osmo-mgw[master]: mgcp-client: Call osmo_fd_unregister() before closing and changing bf... - gerrit-log

14 Mar 2023


      Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31899 )
Change subject: mgcp-client: Call osmo_fd_unregister() before closing and changing bfd->fd
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/31899/comment/27e69ef1_3800bf9e 
PS1, Line 910: osmo_fd_is_registered
...
Hmm-hmm. […]
No. The API explicitly expects the user to make sure osmo_fd_unregister is only called on a registered osmo_fd.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31899
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I95fbcc21a18cadd2c06608cc39b9fe8e12c8bccf
Gerrit-Change-Number: 31899
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 14 Mar 2023 12:46:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment