Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31899 ) Change subject: mgcp-client: Call osmo_fd_unregister() before closing and changing bfd->fd ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/31899/comment/d147dc49_1b3914e4 PS1, Line 910: osmo_fd_is_registered Hmm-hmm. This check can be removed (in a separate patch) because since recently libosmocore does this check for us if compiled with `OSMO_FD_CHECK`. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I95fbcc21a18cadd2c06608cc39b9fe8e12c8bccf Gerrit-Change-Number: 31899 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:45:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment