Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35731?usp=email )
Change subject: add SAIP template handling + v3.1 definitions ......................................................................
Patch Set 1:
(2 comments)
File pySim/esim/saip/templates.py:
https://gerrit.osmocom.org/c/pysim/+/35731/comment/6ad8d394_7faa632d PS1, Line 23: __init__ cosmetic: too many params, may of which are optional. I would go for `**kw` here:
``` def __init__(self, fid:int, name:str, ftype: str, **kw): # ... self.foo = kw.get('foo') # defaults to None self.bar = kw.get('bar', True) # defaults to True ```
https://gerrit.osmocom.org/c/pysim/+/35731/comment/f66bf293_989183cf PS1, Line 531: FilesUsimDf5GSv2 duplicate definition
-
fixeria