Attention is currently required from: laforge.

View Change

2 comments:

• File pySim/esim/saip/templates.py:

  • Patch Set #1, Line 23: __init__

    cosmetic: too many params, may of which are optional. I would go for `**kw` here:

    ```
    def __init__(self, fid:int, name:str, ftype: str, **kw):
        # ...
        self.foo = kw.get('foo') # defaults to None
        self.bar = kw.get('bar', True) # defaults to True
    ```

  • Patch Set #1, Line 531: FilesUsimDf5GSv2

    duplicate definition

To view, visit change 35731. To unsubscribe, or for help writing mail filters, visit settings.