Attention is currently required from: dexter, laforge.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34960?usp=email )

Change subject: transport/pcsc: Allow opening PC/SC readers by a regex of their name ......................................................................

Patch Set 2:

(2 comments)

File pySim/transport/pcsc.py:

https://gerrit.osmocom.org/c/pysim/+/34960/comment/aaf1e628_331b7156 PS2, Line 50: is_a_number(reader_number): Looks like you always expect `reader_number` to be a string: either with the reader number or a regexp. But why does the type is `Union[int, str]` then? Looking at the type I would expect checking like `if type(reader_number) is int`...

https://gerrit.osmocom.org/c/pysim/+/34960/comment/914df167_f35cc43e PS2, Line 132: '--pcsc-device (just a suggestion) maybe keep this argument unchanged (and keep it as `int`), and add another one like `--pcsc-device-regexp` (`type=str`)?