Attention is currently required from: dexter, laforge.

View Change

2 comments:

• File pySim/transport/pcsc.py:

  • Patch Set #2, Line 50: is_a_number(reader_number):

    Looks like you always expect `reader_number` to be a string: either with the reader number or a regexp. But why does the type is `Union[int, str]` then? Looking at the type I would expect checking like `if type(reader_number) is int`...

  • Patch Set #2, Line 132: '--pcsc-device

    (just a suggestion) maybe keep this argument unchanged (and keep it as `int`), and add another one like `--pcsc-device-regexp` (`type=str`)?

To view, visit change 34960. To unsubscribe, or for help writing mail filters, visit settings.