Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28669 )

Change subject: trxcon: rework L1CTL socket API to support multiple clients ......................................................................

Patch Set 5:

(2 comments)

File src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/5c0aef2e_fb73e1f6 PS4, Line 29: l1ctl_conn_data_func *conn_read_cb; /* mandatory */

Done

I meant an "ops" from "operations", aka only function pointers, a virtual table of methods. Not sure where the "opts" comes from, and definetly shouldn't come with pointers to data types.

File src/host/trxcon/src/l1ctl_link.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/69617acc_bad999bd PS5, Line 223: osmo_fd_setup(&server->ofd, -1, OSMO_FD_READ, &l1ctl_server_conn_cb, server, 0); Are you sure passing &func is correct here? look at all the osmo_fd_setup in osmocom code.