Attention is currently required from: fixeria.

View Change

2 comments:

• File src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h:

  • Patch Set #4, Line 29: l1ctl_conn_data_func *conn_read_cb; /* mandatory */

    Done

    I meant an "ops" from "operations", aka only function pointers, a virtual table of methods. Not sure where the "opts" comes from, and definetly shouldn't come with pointers to data types.

• File src/host/trxcon/src/l1ctl_link.c:

  • Patch Set #5, Line 223: osmo_fd_setup(&server->ofd, -1, OSMO_FD_READ, &l1ctl_server_conn_cb, server, 0);

    Are you sure passing &func is correct here? look at all the osmo_fd_setup in osmocom code.

To view, visit change 28669. To unsubscribe, or for help writing mail filters, visit settings.