Attention is currently required from: fixeria, pespin.

laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964?usp=email )

Change subject: pfcp_peer: do not route incoming PDUs without SEID ......................................................................

Patch Set 5: Code-Review+1

(1 comment)

File src/pfcp_peer.erl:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964/comment/8e334a47_cccfc... : PS1, Line 233: ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU])

Going back to this idea, I checked 3GPP TS 29.244 and here is what it states: […]

ok, agreed to not return an PFCP error if there is no such message type, and given the spec references.

We should at least have a metric counter though that users can observe this counter incrementing and therefore get an idea this is happening at all.