Attention is currently required from: fixeria, pespin.
Patch set 5:Code-Review +1
View Change
1 comment:
File src/pfcp_peer.erl:
Patch Set #1, Line 233: ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU])
Going back to this idea, I checked 3GPP TS 29.244 and here is what it states: […]
ok, agreed to not return an PFCP error if there is no such message type, and given the spec references.
We should at least have a metric counter though that users can observe this counter incrementing and therefore get an idea this is happening at all.
To view, visit change 37964. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7d33ec4e883b217b2b4f65e4866d9365c32c753d
Gerrit-Change-Number: 37964
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 25 Oct 2024 14:53:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>