Attention is currently required from: daniel, laforge.

arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email )

Change subject: logging_gsmtap: Temporarily disable logging when sending the logs ......................................................................

Patch Set 1: -Code-Review

(1 comment)

File src/core/logging_gsmtap.c:

https://gerrit.osmocom.org/c/libosmocore/+/34966/comment/e6fa2182_1f906d51 PS1, Line 119: target->loglevel = LOGL_FATAL + 1; Just learned something new from reviewing another patch... maybe we should use `UINT8_MAX` here instead to make this future proof (log levels are stored as `uint8_t` everywhere as far as I can tell)?

At least here https://gerrit.osmocom.org/c/libosmocore/+/30633/comments/18697f9c_0e5e4419 there is talk about introducing a new define for max. log levels to avoid future code from breaking