Attention is currently required from: daniel, laforge.

Patch set 1:-Code-Review

View Change

1 comment:

• File src/core/logging_gsmtap.c:

  • Patch Set #1, Line 119: target->loglevel = LOGL_FATAL + 1;

    Just learned something new from reviewing another patch... maybe we should use `UINT8_MAX` here instead to make this future proof (log levels are stored as `uint8_t` everywhere as far as I can tell)?

    At least here https://gerrit.osmocom.org/c/libosmocore/+/30633/comments/18697f9c_0e5e4419 there is talk about introducing a new define for max. log levels to avoid future code from breaking

To view, visit change 34966. To unsubscribe, or for help writing mail filters, visit settings.