Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email ) Change subject: sccp: Introduce initial support for SCCP LUDT + LUDTS messages ...................................................................... Patch Set 3: (5 comments) File include/osmocom/sccp/sccp_types.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/87eeecf1_f8e0f0f6 PS2, Line 505: #if VARIABLE I see that this is elsewhere in the file too, but being curious: are the "if VARIABLE" and "if OPTIONAL" blocks just comments? https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/a1fcfa74_bad67a50 PS2, Line 529: indent with one less tab here for consistency with the rest of the file? https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/9b015c1f_2b32a267 PS2, Line 543: importancd importance (same typo is elsewhere in the file too) File src/sccp2sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/9f729b5d_d5ba6ae4 PS2, Line 1449: sccp_longdata_to_sua_ptr(xua, SUA_IEI_DATA, (uint8_t *)&ludt->variable_data); there's probably a reason, but to be sure: why not run sccp_longptr_part_consistent again here, and after sccp_to_xua_opt below? same with sccp_to_xua_ludts File tests/xua/xua_test.ok: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/61d4196a_dcbe7552 PS2, Line 102: Input != re-encoded output! is this expected? if so, maybe add a comment about it like done in the previous patch? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ic91abfc921f5e4f36045bfa325333112cddd9fa6 Gerrit-Change-Number: 34467 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:47:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment