Attention is currently required from: pespin.

View Change

5 comments:

• File include/osmocom/sccp/sccp_types.h:

  • Patch Set #2, Line 505: #if VARIABLE

    I see that this is elsewhere in the file too, but being curious: are the "if VARIABLE" and "if OPTIONAL" blocks just comments?

  • Patch Set #2, Line 529:

    indent with one less tab here for consistency with the rest of the file?

  • Patch Set #2, Line 543: importancd

    importance (same typo is elsewhere in the file too)

• File src/sccp2sua.c:

  • Patch Set #2, Line 1449: sccp_longdata_to_sua_ptr(xua, SUA_IEI_DATA, (uint8_t *)&ludt->variable_data);

    there's probably a reason, but to be sure: why not run sccp_longptr_part_consistent again here, and after sccp_to_xua_opt below? same with sccp_to_xua_ludts

• File tests/xua/xua_test.ok:

  • Patch Set #2, Line 102: Input != re-encoded output!

    is this expected? if so, maybe add a comment about it like done in the previous patch?

To view, visit change 34467. To unsubscribe, or for help writing mail filters, visit settings.