Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27371 )

Change subject: add counter for inter-BSC incoming Handover Request ......................................................................

Patch Set 4: Code-Review+2

(2 comments)

Patchset:

PS4: For the record: The counter names should be cleaned up in a subsequent patch.

File src/osmo-bsc/osmo_bsc_msc.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27371/comment/3b56041f_2b27eceb PS2, Line 58: [MSC_CTR_BSSMAP_RX_DT1_HANDOVER_RQST] = {"bssmap:rx:dt1:handover:rqst", "Number of received BSSMAP DT1 HANDOVER RQST messages"},

that's true. […]

we definitely don't want separate counters. It never made any sense at all to include the SCCP message type in the counter name, not sure what the rationale was for that? I mean, we're als not including that this is sent in a M3UA DATA message and a SCCP DATA chunk and an IP packet and an Ethernet frame...