Attention is currently required from: neels.

Patch set 4:Code-Review +2

View Change

2 comments:

• Patchset:

  • Patch Set #4:

    For the record: The counter names should be cleaned up in a subsequent patch.

• File src/osmo-bsc/osmo_bsc_msc.c:

  • Patch Set #2, Line 58: [MSC_CTR_BSSMAP_RX_DT1_HANDOVER_RQST] = {"bssmap:rx:dt1:handover:rqst", "Number of received BSSMAP DT1 HANDOVER RQST messages"},

    that's true. […]

    we definitely don't want separate counters. It never made any sense at all to include the SCCP message type in the counter name, not sure what the rationale was for that? I mean, we're als not including that this is sent in a M3UA DATA message and a SCCP DATA chunk and an IP packet and an Ethernet frame...

To view, visit change 27371. To unsubscribe, or for help writing mail filters, visit settings.