Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 ) Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/db_auc.c: https://gerrit.osmocom.org/c/osmo-hlr/+/28424/comment/0a485351_e219fe18 PS1, Line 99: return osmo_hexparse((void *)text, dst, dst_len) == col_len; This is wrong, osmo_hexparse returns "number of parsed octets", not zero. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Gerrit-Change-Number: 28424 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 11:01:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment