Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 )
Change subject: cbc: Test ETWS msg over CBSP ......................................................................
Patch Set 3:
(2 comments)
File cbc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/39211574_5feca... PS3, Line 101: var template (omit) uint8_t channel_ind := omit;
AFAIU, if msg.channel_ind is omitted, then channel_ind would also be equal to omit. […]
I think I got problems there about the field being uninitialized, because as part of a record it's not a template, but an optional field, which is not exactly the same I think. For instance, I think one should use "ispresent()" there, not istemplatekind().
File cbc/CBC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/8b75260a_2bf2a... PS3, Line 353: g_pars.exp_cbs_msg.channel_ind
Here I guess you're doing ispresent() because g_pars. […]
no, because msg.channel_ind field is optional, since ETWS messages don't contain a channel_ind.
-
pespin