Attention is currently required from: osmith, fixeria.

View Change

2 comments:

• File cbc/BSC_ConnectionHandler.ttcn:

  • Patch Set #3, Line 101: var template (omit) uint8_t channel_ind := omit;

    AFAIU, if msg.channel_ind is omitted, then channel_ind would also be equal to omit. […]

    I think I got problems there about the field being uninitialized, because as part of a record it's not a template, but an optional field, which is not exactly the same I think.
    For instance, I think one should use "ispresent()" there, not istemplatekind().

• File cbc/CBC_Tests.ttcn:

  • Patch Set #3, Line 353: g_pars.exp_cbs_msg.channel_ind

    Here I guess you're doing ispresent() because g_pars. […]

    no, because msg.channel_ind field is optional, since ETWS messages don't contain a channel_ind.

To view, visit change 28912. To unsubscribe, or for help writing mail filters, visit settings.