Attention is currently required from: laforge.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40270?usp=email )

Change subject: vty: Allow setting cnlink msc/sgsn name ......................................................................

Patch Set 2:

(1 comment)

File src/osmo-hnbgw/cnlink.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/40270/comment/d1a6cf02_ec3d013f?us... : PS2, Line 237: osmo_fsm_inst_update_id_f_sanitize(cnlink->fi, '-', cnlink->name);

in theory osmo_fsm_inst_update_id_f_sanitize could fail, more likely than the others below. […]

Yeah I thought about that while writing the patch. I guess in this weird case we are fine assuming the logging may be wrong. Otherwise we'd need to somehow revert the new string being applied on other places before the failure, which may create quite a lot of complexity.

TBH I personally like this kind of APIs returning an return-code integer even if right now we don't return an error in the implementation.