Attention is currently required from: laforge.

View Change

1 comment:

• File src/osmo-hnbgw/cnlink.c:

  • Patch Set #2, Line 237: osmo_fsm_inst_update_id_f_sanitize(cnlink->fi, '-', cnlink->name);

    in theory osmo_fsm_inst_update_id_f_sanitize could fail, more likely than the others below. […]

    Yeah I thought about that while writing the patch.
    I guess in this weird case we are fine assuming the logging may be wrong. Otherwise we'd need to somehow revert the new string being applied on other places before the failure, which may create quite a lot of complexity.

    TBH I personally like this kind of APIs returning an return-code integer even if right now we don't return an error in the implementation.

To view, visit change 40270. To unsubscribe, or for help writing mail filters, visit settings.