Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28896 ) Change subject: abis_om2000: duplicate nmstate of bb_trxc mo to trx mo ...................................................................... Patch Set 2: (7 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/28896/comment/81490f9c_a5fd550b PS1, Line 9: In OM2000 a separate bb_trxc MO does not exist to archive better Done https://gerrit.osmocom.org/c/osmo-bsc/+/28896/comment/eeff464d_c1b7a070 PS1, Line 10: compatibilty towards classic ABIS and its MOs lets mirror the nmstate of Done File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28896/comment/fb615d8f_32a6f4f2 PS1, Line 1011: switch (mo_state) { Done https://gerrit.osmocom.org/c/osmo-bsc/+/28896/comment/daafb537_edba490f PS1, Line 1032: duplicate_trxc_nm_state(bts, mo); I am doing this in a separate function now. However, I am not sure how to set nsd.obj. What also makes me wonder is why we do not set nsd.obj_class. How does the receiving entity know the kind of object is in nsd.obj? https://gerrit.osmocom.org/c/osmo-bsc/+/28896/comment/254da984_44d2cb2d PS1, Line 1058: duplicate_trxc_nm_state(bts, mo); Done https://gerrit.osmocom.org/c/osmo-bsc/+/28896/comment/4607e8fe_9f0f3850 PS1, Line 1059: } I think you are correct. I have fixed this in a different patch before this one. https://gerrit.osmocom.org/c/osmo-bsc/+/28896/comment/45c93bce_947b2ccd PS1, Line 2245: otfp->trx->bb_transc.mo.nm_state.administrative = NM_STATE_UNLOCKED; I have addressed this in a different patch before this one now. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4611d8af16a30725308bd527098b12a356bfde9f Gerrit-Change-Number: 28896 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 15:43:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment