Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29950 )
Change subject: support for e1-tracer hardware ......................................................................
Patch Set 1:
(1 comment)
File src/usb.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/29950/comment/7a857754_6695fc18 PS1, Line 993: if (!is_tracer) {
I would just test on if (line_data->ep_out) and if (line_data->ep_fb) rather than is_tracer. […]
that unfortunately then would also be true for the existing/legacy USB descriptors of e1-tracer with old firmware. Ok, now with the set_configuration(2) above, that shouldn't happen anymore. Probably best to at least check that the set_configuation succeeds, as otherwise we have an old e1-tracer with the old interface and osmo-e1d would happily open half of the endpoints of the legacy interface :(
-
laforge