Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29950 ) Change subject: support for e1-tracer hardware ...................................................................... Patch Set 1: (1 comment) File src/usb.c: https://gerrit.osmocom.org/c/osmo-e1d/+/29950/comment/7a857754_6695fc18 PS1, Line 993: if (!is_tracer) {
I would just test on if (line_data->ep_out) and if (line_data->ep_fb) rather than is_tracer. […] that unfortunately then would also be true for the existing/legacy USB descriptors of e1-tracer with old firmware. Ok, now with the set_configuration(2) above, that shouldn't happen anymore. Probably best to at least check that the set_configuation succeeds, as otherwise we have an old e1-tracer with the old interface and osmo-e1d would happily open half of the endpoints of the legacy interface :(
-- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I855e18c0f229bd473123f96303e60ab2de90677f Gerrit-Change-Number: 29950 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: tnt <tnt@246tNt.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 17:12:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <tnt@246tNt.com> Gerrit-MessageType: comment