Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 )
Change subject: cfg: add 'hnbgw' / 'plmn MCC MNC' ......................................................................
Patch Set 5:
(2 comments)
File src/osmo-hnbgw/hnbgw_l3.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178/comment/94784798_295b9cdb PS3, Line 281: osmo_plmn_from_bcd(ies->lai.pLMNidentity.buf, &local_plmn);
so, even if the behavior changes are minimal based on whether the PLMN is configured or not, and giv […]
i just told you that we are very loud on the log about a missing PLMN in the config file.
File src/osmo-hnbgw/hnbgw_vty.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178/comment/bcfde02b_d2fe9d80 PS5, Line 285: <1-999> <0-999>
Yes, because they are handled as strings and properly parsed by osmo_mcc_from_str()/osmo_mnc_from_st […]
yes, also notably because leading zeros are still passed on to the DEFUN function and we evaluate the string with those functions instead of using atoi().
-
neels