Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File src/osmo-hnbgw/hnbgw_l3.c:

  • Patch Set #3, Line 281: osmo_plmn_from_bcd(ies->lai.pLMNidentity.buf, &local_plmn);

    so, even if the behavior changes are minimal based on whether the PLMN is configured or not, and giv […]

    i just told you that we are very loud on the log about a missing PLMN in the config file.

• File src/osmo-hnbgw/hnbgw_vty.c:

  • Patch Set #5, Line 285: <1-999> <0-999>

    Yes, because they are handled as strings and properly parsed by osmo_mcc_from_str()/osmo_mnc_from_st […]

    yes, also notably because leading zeros are still passed on to the DEFUN function and we evaluate the string with those functions instead of using atoi().

To view, visit change 33178. To unsubscribe, or for help writing mail filters, visit settings.