Attention is currently required from: neels, laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 )
Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ......................................................................
Patch Set 14:
(3 comments)
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/56fc9585_4b6c502b PS4, Line 580: if (prim && msgb_l2(prim->oph.msg) && msgb_l2len(prim->oph.msg)) {
exit early […]
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/74875340_b63c288a PS4, Line 585: xua_msg_free(xua);
I agree, it feels rather odd if a function supposedly adding a bit to caller-provided 'xua' suddenly […]
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/8fa01b13_7a79393a PS4, Line 615: if (!xua_add_data(prim, xua, "4.2"))
this looks like a mem leak of above xua_msg_alloc(). […]
Done
-
msuraev