Attention is currently required from: neels, laforge.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 )
Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD
......................................................................
Patch Set 14:
(3 comments)
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/56fc9585_4b6c502b
PS4, Line 580: if (prim && msgb_l2(prim->oph.msg) &&
msgb_l2len(prim->oph.msg)) {
exit early […]
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/74875340_b63c288a
PS4, Line 585: xua_msg_free(xua);
I agree, it feels rather odd if a function supposedly
adding a bit to caller-provided 'xua' suddenly […]
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/8fa01b13_7a79393a
PS4, Line 615: if (!xua_add_data(prim, xua, "4.2"))
this looks like a mem leak of above xua_msg_alloc().
[…]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a
Gerrit-Change-Number: 29084
Gerrit-PatchSet: 14
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 23 Aug 2022 10:15:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment