Attention is currently required from: neels, laforge. 
View Change
3 comments:
File src/sccp_scoc.c:
Patch Set #4, Line 580: 	if (prim && msgb_l2(prim->oph.msg) && msgb_l2len(prim->oph.msg)) {
exit early […]
Done
Patch Set #4, Line 585: 			xua_msg_free(xua);
I agree, it feels rather odd if a function supposedly adding a bit to caller-provided 'xua' suddenly […]
Done
Patch Set #4, Line 615: 		if (!xua_add_data(prim, xua, "4.2"))
this looks like a mem leak of above xua_msg_alloc(). […]
Done
To view, visit change 29084. To unsubscribe, or for help writing mail filters, visit settings.
 Gerrit-Project: libosmo-sccp 
 Gerrit-Branch: master 
 Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a 
 Gerrit-Change-Number: 29084 
 Gerrit-PatchSet: 14 
 Gerrit-Owner: msuraev <msuraev@sysmocom.de> 
 Gerrit-Reviewer: Jenkins Builder 
 Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> 
 Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> 
 Gerrit-CC: laforge <laforge@osmocom.org> 
 Gerrit-Attention: neels <nhofmeyr@sysmocom.de> 
 Gerrit-Attention: laforge <laforge@osmocom.org> 
 Gerrit-Comment-Date: Tue, 23 Aug 2022 10:15:10 +0000 
 Gerrit-HasComments: Yes 
 Gerrit-Has-Labels: No 
 Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> 
 Comment-In-Reply-To: laforge <laforge@osmocom.org> 
 Gerrit-MessageType: comment