Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27951 )
Change subject: abis_nm_ipaccess_rsl_connect: initialize ia ......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/abis_nm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27951/comment/663921d2_660fe6d6 PS1, Line 3050: /* if ip == 0, we use the default IP */
what is the "default IP" here? It make make sense to fill ia with it in order to have meaningul logg […]
As I understand it, this function generates a the ipaccess RSL connect message and sends it, and this "if ip == 0, we use the default IP" comment seems to refer to:
https://gitea.osmocom.org/cellular-infrastructure/osmo-bts/src/commit/d99e20...
If ip is 0, it does not get added to the msgb. With this patch, it gets printed as 0.0.0.0:
GSMTAP libosmocore logging OsmoBSC(82839): NM/3: abis_nm.c:3057 (bts=1,trx=0) IPA RSL CONNECT IP=0.0.0.0 PORT=3003 STREAM=0x00
So I'd leave this as is. Or would you change the log message?
-
osmith