Attention is currently required from: pespin.

View Change

1 comment:

• File src/osmo-bsc/abis_nm.c:

  • Patch Set #1, Line 3050: /* if ip == 0, we use the default IP */

    what is the "default IP" here? It make make sense to fill ia with it in order to have meaningul logg […]

    As I understand it, this function generates a the ipaccess RSL connect message and sends it, and this "if ip == 0, we use the default IP" comment seems to refer to:

    https://gitea.osmocom.org/cellular-infrastructure/osmo-bts/src/commit/d99e20f97ab4708453514b90d542d8457ba8367a/src/common/rsl.c#L2894

    If ip is 0, it does not get added to the msgb. With this patch, it gets printed as 0.0.0.0:

      GSMTAP libosmocore logging OsmoBSC(82839): NM/3: abis_nm.c:3057 (bts=1,trx=0) IPA RSL CONNECT IP=0.0.0.0 PORT=3003 STREAM=0x00

    So I'd leave this as is. Or would you change the log message?

To view, visit change 27951. To unsubscribe, or for help writing mail filters, visit settings.