[S] Change in osmo-dev[master]: gen_makefile: support new Osmocom erlang makefiles - gerrit-log

29 Jul 2025

Attention is currently required from: osmith, pespin.

fixeria has posted comments on this change by osmith. (
https://gerrit.osmocom.org/c/osmo-dev/+/40770?usp=email )

Change subject: gen_makefile: support new Osmocom erlang makefiles
......................................................................

Patch Set 1:

(1 comment)

File gen_makefile.py:

https://gerrit.osmocom.org/c/osmo-dev/+/40770/comment/91dd719a_1335f8b0?usp… :
PS1, Line 375: for i in {build_proj}/default/bin/*; do \\
             :       if [ -e "$$i" ]; then \\
             :         install -v -Dm755 "$$i" -t
{shlex.quote(args.install_prefix)}/bin/; \\
...
  Oh interesting! Apparently this doesn't get
created in default/bin when REBAR_BASE_DIR is set [...] 
I confirm that `dest/default/bin/setup_gen` does not get created when doing
`REBAR_BASE_DIR=dest make release`. This is indeed weird, but yeah, I would not rely on
checking presence of `dest/default/bin/*`.

...
  I would also have preferred this, but the problem is
that the Makefile before https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40756 already has
an install target, so this does not work. 
Yes, but what's wrong with that? The old `install` recipe will install an escript, the
new recipe will install complete release package and a bootstrap/launcher script. In both
cases we'll end up with `$(DESTDIR)/usr/bin/osmo-app`. The key difference is how we
pass the config file, but this is not a problem since we have `program=` and
`program_latest=` in testenv, right?

...
  However, how about we add an install-osmo-dev: install
target to the Makefile to make it explicit what osmo-dev should do [...] 
TBH, I don't like this idea of adding an osmo-dev specific recipe, sorry.
Let's see if this is needed at all (see my thought above).

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40770?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I92d6fc6eb5a11068d4b3baca55dfb3abdedbbbf1
Gerrit-Change-Number: 40770
Gerrit-PatchSet: 1
Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Tue, 29 Jul 2025 21:17:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith &lt;osmith(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;