Attention is currently required from: osmith, pespin.
1 comment:
File gen_makefile.py:
for i in {build_proj}/default/bin/*; do \\
if [ -e "$$i" ]; then \\
install -v -Dm755 "$$i" -t {shlex.quote(args.install_prefix)}/bin/; \\
Oh interesting! Apparently this doesn't get created in default/bin when REBAR_BASE_DIR is set [...]
I confirm that `dest/default/bin/setup_gen` does not get created when doing `REBAR_BASE_DIR=dest make release`. This is indeed weird, but yeah, I would not rely on checking presence of `dest/default/bin/*`.
I would also have preferred this, but the problem is that the Makefile before https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40756 already has an install target, so this does not work.
Yes, but what's wrong with that? The old `install` recipe will install an escript, the new recipe will install complete release package and a bootstrap/launcher script. In both cases we'll end up with `$(DESTDIR)/usr/bin/osmo-app`. The key difference is how we pass the config file, but this is not a problem since we have `program=` and `program_latest=` in testenv, right?
However, how about we add an install-osmo-dev: install target to the Makefile to make it explicit what osmo-dev should do [...]
TBH, I don't like this idea of adding an osmo-dev specific recipe, sorry.
Let's see if this is needed at all (see my thought above).
To view, visit change 40770. To unsubscribe, or for help writing mail filters, visit settings.