Attention is currently required from: pespin, fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support ......................................................................
Patch Set 11:
(6 comments)
File .gitignore:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cf4a5e8_a523dac5 PS3, Line 10: Transceiver52M/osmo-trx-ipc2
This doesn't belong to this commit afaiu.
Done
File Transceiver52M/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e7b2096_994f5744 PS3, Line 27: AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/
Is it OK if the submodule isn't there and the patch doesn't exist? I guess it's fine, the compiler j […]
just paths used for searching, compiler doesn't care.
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97e0f637_37bbbed7 PS3, Line 28: AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/
What about filling a LIBTRXCON_CFLAGS/LIBS in configure? It would be way more cleaner.
see the new changes , i'd rather keep it in one place, since it is ltlibs anyway and splitting it obfuscates it.
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a472fdb_6af6b51b PS3, Line 82: $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libl1sched.a \
LIBTRXCON_LIBS in configure. […]
Done
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a2870f13_9e6c4827 PS3, Line 124: $(TRXCON_LDADD)
LIBTRXCON_LIBS in configure. […]
Done
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5e6e874_8dbf5124 PS3, Line 187: # bin_PROGRAMS += osmo-trx-ipc2
This doesn't belong to this patch.
Done
-
Hoernchen