Attention is currently required from: pespin, fixeria.

View Change

6 comments:

• File .gitignore:

  • Patch Set #3, Line 10: Transceiver52M/osmo-trx-ipc2

    This doesn't belong to this commit afaiu.

    Done

• File Transceiver52M/Makefile.am:

  • Patch Set #3, Line 27: AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/

    Is it OK if the submodule isn't there and the patch doesn't exist? I guess it's fine, the compiler j […]

    just paths used for searching, compiler doesn't care.

  • Patch Set #3, Line 28: AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/

    What about filling a LIBTRXCON_CFLAGS/LIBS in configure? It would be way more cleaner.

    see the new changes , i'd rather keep it in one place, since it is ltlibs anyway and splitting it obfuscates it.

  • Patch Set #3, Line 82: $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libl1sched.a \

    LIBTRXCON_LIBS in configure. […]

    Done

  • Patch Set #3, Line 124: $(TRXCON_LDADD)

    LIBTRXCON_LIBS in configure. […]

    Done

  • Patch Set #3, Line 187: # bin_PROGRAMS += osmo-trx-ipc2

    This doesn't belong to this patch.

    Done

To view, visit change 30416. To unsubscribe, or for help writing mail filters, visit settings.