Attention is currently required from: osmith, pespin, fixeria.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 )

Change subject: Move out of alloc_algo code modifying the data model ......................................................................

Patch Set 8:

(5 comments)

File src/alloc_algo.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/79bcab0e_99e8bfe3 PS8, Line 761: memset(res->usf, -1, sizeof(res->usf)); Are you sure this is correct? `sizeof(res->usf)` is not 8 in this case, but `sizeof(int) * 8`. This will likely work for `-1`, because it's basically `0xffffffff`, but doing e.g. `memset(res->usf, 1, sizeof(res->usf))` will result in 0x1010101 being written to each array item. Not critical, but I would rather avoid it for the good and init using a for-loop.

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/52a151b4_fee57e13 PS8, Line 800: res->usf `&res->usf[0]` would be cleaner here, otherwise it looks like you're passing a USF value, but then you go and check the `struct alloc_resources_res` and figure out that it's actually an array.

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/db65f286_12d78ead PS8, Line 863: struct alloc_resources_res *res) coemstic: alignment

File src/tbf.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/ce86fd5d_0847d22d PS7, Line 588:

I'll add a comma. It's not really "and", it's more a cause->consequence or equal thing.

Done

File src/tbf_ul.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/47086095_3df413cf PS8, Line 720: %u `%d` because it's int?