Attention is currently required from: osmith, pespin, fixeria.
5 comments:
File src/alloc_algo.cpp:
Patch Set #8, Line 761: memset(res->usf, -1, sizeof(res->usf));
Are you sure this is correct? `sizeof(res->usf)` is not 8 in this case, but `sizeof(int) * 8`. This will likely work for `-1`, because it's basically `0xffffffff`, but doing e.g. `memset(res->usf, 1, sizeof(res->usf))` will result in 0x1010101 being written to each array item. Not critical, but I would rather avoid it for the good and init using a for-loop.
Patch Set #8, Line 800: res->usf
`&res->usf[0]` would be cleaner here, otherwise it looks like you're passing a USF value, but then you go and check the `struct alloc_resources_res` and figure out that it's actually an array.
Patch Set #8, Line 863: struct alloc_resources_res *res)
coemstic: alignment
File src/tbf.cpp:
I'll add a comma. It's not really "and", it's more a cause->consequence or equal thing.
Done
File src/tbf_ul.cpp:
`%d` because it's int?
To view, visit change 32399. To unsubscribe, or for help writing mail filters, visit settings.