Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837 )
Change subject: tests/ranap_rab_ass: fix NULL pointer dereference ......................................................................
Patch Set 1:
(1 comment)
File tests/ranap_rab_ass/ranap_rab_ass_test.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837/comment/e8084232_882b8db9 PS1, Line 67: if (encoded != NULL) { I'm a bit lost here. Is this really returning encoded=NULL at all? the commit message seems to be indicating so, but I doubt it. If at all, it should be "Fix potential null pointer dereference". In any case, I think adding an OSMO_ASSERT(encoded) would be preferable here.