Attention is currently required from: fixeria.

View Change

1 comment:

• File tests/ranap_rab_ass/ranap_rab_ass_test.c:

  • Patch Set #1, Line 67: if (encoded != NULL) {

    I'm a bit lost here. Is this really returning encoded=NULL at all? the commit message seems to be indicating so, but I doubt it.
    If at all, it should be "Fix potential null pointer dereference".
    In any case, I think adding an OSMO_ASSERT(encoded) would be preferable here.

To view, visit change 28837. To unsubscribe, or for help writing mail filters, visit settings.