Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38635?usp=email ) Change subject: global_platform/scp: refactor _wrap_cmd_apdu ...................................................................... Patch Set 1: (2 comments) File pySim/global_platform/scp.py: https://gerrit.osmocom.org/c/pysim/+/38635/comment/7d232cc8_2bd6f256?usp=em… : PS1, Line 279: if self.do_cmac: Adding another indention level does not make functions more readable either... Maybe do an early return? ``` if not self.do_cmac: return apdu ``` https://gerrit.osmocom.org/c/pysim/+/38635/comment/f6535e88_3a633a76?usp=em… : PS1, Line 482: if self.do_cmac: Likewise, maybe do an early return? ``` if not self.do_cmac: return apdu ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38635?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4c5650337779a4bd1f98673650c6c3cb526d518b Gerrit-Change-Number: 38635 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 19:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No