Attention is currently required from: dexter.

View Change

2 comments:

• File pySim/global_platform/scp.py:

  • Patch Set #1, Line 279: if self.do_cmac:

    Adding another indention level does not make functions more readable either...

    Maybe do an early return?

    ```
    if not self.do_cmac:
        return apdu
    ```

  • Patch Set #1, Line 482: if self.do_cmac:

    Likewise, maybe do an early return?

    ```
    if not self.do_cmac:
        return apdu
    ```

To view, visit change 38635. To unsubscribe, or for help writing mail filters, visit settings.