Attention is currently required from: Timur Davydov, laforge.
fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email )
Change subject: transceiver: return -EINVAL for invalid SETSLOT ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/775fa00d_e32135aa?usp=... : PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */
I've updated it so that an invalid timeslot now results in an error instead of being ignored.
If you return early, you bypass `transceiver->ctrl_sock_send()` and the error response is never sent. This is wrong. Does the caller of this function really care about returned value?
-
fixeria