Attention is currently required from: Timur Davydov, laforge.

Patch set 2:Code-Review -1

View Change

1 comment:

• File Transceiver52M/Transceiver.cpp:

  • Patch Set #1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */

    I've updated it so that an invalid timeslot now results in an error instead of being ignored.

    If you return early, you bypass `transceiver->ctrl_sock_send()` and the error response is never sent. This is wrong. Does the caller of this function really care about returned value?

To view, visit change 42421. To unsubscribe, or for help writing mail filters, visit settings.