Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33691 )
Change subject: split pySim/legacy/{cards,utils} from pySim/{cards,utils}
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
- You're missing to add `__init__.py` to new submodules. […]
I had no idea that __init__.py was mandatory even if it doesn't actually contain any code. I have close to zero knowlege about setup.py and/or other python installers. Thanks.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/33691
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia8cf831929730c48f90679a83d69049475cc5077
Gerrit-Change-Number: 33691
Gerrit-PatchSet: 5
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 12 Jul 2023 18:45:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment