Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33690 ) Change subject: pySim/cards: Split legacy classes away from core SIM + UICC ...................................................................... Patch Set 4: (2 comments) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/33690/comment/72190f20_2f433eab PS4, Line 31: base class

Do we want to make it an abstract base class (`@abc. […] possibly, I'm not entirely sure which way this will develop. In general, the entire 'CardBase + subclasses' here in the non-legacy module has very little functionality, the real work is in SmartCardCommands (which is also ugly as it mixes commands for SIM + UICC in one class, ...).

https://gerrit.osmocom.org/c/pysim/+/33690/comment/9d1f4fc8_c0be856c PS4, Line 41: self._aids = []

unreachable code thanks, this should be in the constructor.

-- To view, visit https://gerrit.osmocom.org/c/pysim/+/33690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id36140675def5fc44eedce81fc7b09e0adc527e1 Gerrit-Change-Number: 33690 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 18:47:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment