Attention is currently required from: fixeria, dexter.

View Change

2 comments:

• File pySim/cards.py:

  • Patch Set #4, Line 31: base class

    Do we want to make it an abstract base class (`@abc. […]

    possibly, I'm not entirely sure which way this will develop. In general, the entire 'CardBase + subclasses' here in the non-legacy module has very little functionality, the real work is in SmartCardCommands (which is also ugly as it mixes commands for SIM + UICC in one class, ...).

  • Patch Set #4, Line 41: self._aids = []

    unreachable code

    thanks, this should be in the constructor.

To view, visit change 33690. To unsubscribe, or for help writing mail filters, visit settings.