Attention is currently required from: jolly.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email )

Change subject: ASCI: Prepare gsm48_rr_rx_acch for voice group channel ......................................................................

Patch Set 3:

(4 comments)

File src/host/layer23/src/mobile/gsm48_rr.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/56bd95db_5345a46b PS3, Line 4882: N201_Bter_SACCH These defines can also be found is libosmocore.git. But I see that they're not in a header file, unfortunately.

https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/89ef37d5_0ec61e83 PS3, Line 4889: struct gsm48_system_information_type_header *sih; : struct gsm48_hdr_sh *sgh; : struct gsm48_hdr *gh; all `const`?

https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/a4121561_73e6e496 PS3, Line 4895: sgh = msgb_l3(msg); do we want to check `if (msgb_l3len(msg) < sizeof(*sgh))` here?

https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/d194695f_932eac3a PS3, Line 4909: sih = msgb_l3(msg); do we want to check `if (msgb_l3len(msg) < sizeof(*sih))` here?