Attention is currently required from: jolly.

View Change

4 comments:

• File src/host/layer23/src/mobile/gsm48_rr.c:

  • Patch Set #3, Line 4882: N201_Bter_SACCH

    These defines can also be found is libosmocore.git.
    But I see that they're not in a header file, unfortunately.

  • Patch Set #3, Line 4889:

    struct gsm48_system_information_type_header *sih;
    	struct gsm48_hdr_sh *sgh;
    	struct gsm48_hdr *gh;
    

    all `const`?

  • Patch Set #3, Line 4895: sgh = msgb_l3(msg);

    do we want to check `if (msgb_l3len(msg) < sizeof(*sgh))` here?

  • Patch Set #3, Line 4909: sih = msgb_l3(msg);

    do we want to check `if (msgb_l3len(msg) < sizeof(*sih))` here?

To view, visit change 34529. To unsubscribe, or for help writing mail filters, visit settings.