[S] Change in osmo-bsc[master]: pcuif_proto: check confirm flag in struct gsm_pcu_if_pch - gerrit-log

29 Aug 2023

Attention is currently required from: osmith, dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192
)

Change subject: pcuif_proto: check confirm flag in struct gsm_pcu_if_pch
......................................................................

Patch Set 3:

(2 comments)

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/d1b91702_425d377d 
PS2, Line 559: 			if (!pch->confirm)
I'm not really following.

...
  The problem is that we can not really chose here if we
want a confirmation or not. 
Who is "we" here? in which piece of software?

...
  The Ericsson RBS BTS will send the IMM ASS send
message whether we want it or not. And this will generate a confirmation. 
What do you mean here with "will send a IMM ASS whether we want it or not"?

...
  As far as I understand, you would use the
pch->confirm flag to decide if the message has to go through pcu_rx_rr_imm_ass_pch() or
pcu_rx_rr_paging_pch() 
why do you want to do that? pch->confim is to know whether the PCUIF primitive has to
be confirmed. You look the message type to know whether it's an ImmAss or a Paging.

https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/068d3d07_a2fcde4f 
PS2, Line 566: 			if (pch->confirm)
...
  In theory osmo-bts would be capable to confirm paging
MAC blocks. […] Just send the confirmation when you transmit the related block over
RSL. We can later on add some extra parameters in osmo-pcu to incresae the delay, get
estimation delays from the other PCUIF side, etc.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34192
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3d2842626b7e8325860ea3160c7d900d39e953a0
Gerrit-Change-Number: 34192
Gerrit-PatchSet: 3
Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-Comment-Date: Tue, 29 Aug 2023 09:57:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-MessageType: comment