Attention is currently required from: osmith, dexter.

View Change

2 comments:

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #2, Line 559: if (!pch->confirm)

    I'm not really following.

    The problem is that we can not really chose here if we want a confirmation or not.

    Who is "we" here? in which piece of software?

    The Ericsson RBS BTS will send the IMM ASS send message whether we want it or not. And this will generate a confirmation.

    What do you mean here with "will send a IMM ASS whether we want it or not"?

    As far as I understand, you would use the pch->confirm flag to decide if the message has to go through pcu_rx_rr_imm_ass_pch() or pcu_rx_rr_paging_pch()

    why do you want to do that? pch->confim is to know whether the PCUIF primitive has to be confirmed. You look the message type to know whether it's an ImmAss or a Paging.

  • Patch Set #2, Line 566: if (pch->confirm)

    In theory osmo-bts would be capable to confirm paging MAC blocks. […]

    Just send the confirmation when you transmit the related block over RSL. We can later on add some extra parameters in osmo-pcu to incresae the delay, get estimation delays from the other PCUIF side, etc.

To view, visit change 34192. To unsubscribe, or for help writing mail filters, visit settings.